Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrchardCore.ResourceManagement project #17106

Open
MikeAlhayek opened this issue Dec 2, 2024 · 5 comments
Open

Remove OrchardCore.ResourceManagement project #17106

MikeAlhayek opened this issue Dec 2, 2024 · 5 comments
Labels
breaking change 💥 Issues or pull requests that introduces breaking change(s) enhancement
Milestone

Comments

@MikeAlhayek
Copy link
Member

I am not sure why we have three resource management packages

  • OrchardCore.ResourceManagement
  • OrchardCore.ResourceManagement.Core
  • OrchardCore.ResourceManagement.Abstractions

Usually we create a new project if the project is a feature. But in this case, I don't think we need OrchardCore.ResourceManagement project. All of it's content can be relocated to OrchardCore.ResourceManagement.Core project without changing any namespaces.

@sebastienros do you know if this is a must have project for some a reason I am missing?

@sebastienros sebastienros added the breaking change 💥 Issues or pull requests that introduces breaking change(s) label Dec 5, 2024
@sebastienros sebastienros added this to the backlog milestone Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@MikeAlhayek MikeAlhayek modified the milestones: backlog, Future.x Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@ns8482e
Copy link
Contributor

ns8482e commented Dec 6, 2024

core and abstraction are part of orchard core framework whereas the module is part of orchard cms

When introducing breaking changes, please don't forget that we have orchard core framework that can use used in asp.net applications without CMS

@MikeAlhayek
Copy link
Member Author

@ns8482e I understand. If you look in the ResourceManagement project, you'll notices nothing in it that can't be moved to the Core project. It's not CMS specific.

image

@ns8482e
Copy link
Contributor

ns8482e commented Dec 7, 2024

OrchardCore ResourceManagement is framework library that allows asp.net applications to utilize resources.

See nuget dec

    <Description>$(OCFrameworkDescription)

      Provides Resource Management capabilities and useful TagHelpers for commonly used resources like JavaScript libraries and CSS files.</Description>

My two cents - please resist temptation to modify in projects that has tag OCFramework if there is no significant feature additions, please don't change it.

Most times not needed code optimization without significant features improvements results in more bugs and unstable products

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 💥 Issues or pull requests that introduces breaking change(s) enhancement
Projects
None yet
Development

No branches or pull requests

3 participants