Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't two-factor authentication work without cookie consent? #17133

Closed
gvkries opened this issue Dec 6, 2024 · 2 comments · Fixed by #17136
Closed

Shouldn't two-factor authentication work without cookie consent? #17133

gvkries opened this issue Dec 6, 2024 · 2 comments · Fixed by #17136
Assignees

Comments

@gvkries
Copy link
Contributor

gvkries commented Dec 6, 2024

Two-factor authentication is blocked if cookies are not accepted. I think this is not necessary, because authentication cookies are essential and must always be allowed.

See:

var canTrack = ViewContext.HttpContext.Features.Get<ITrackingConsentFeature>()?.CanTrack ?? true;

@if (!canTrack)
{
<div class="alert alert-danger text-center">
<strong>@T["Privacy and cookie policy have not been accepted."]</strong>
<p>@T["You must accept the policy before you can enable two-factor authentication."]</p>
</div>
return;
}

/cc @MikeAlhayek @Piedone

@MikeAlhayek
Copy link
Member

Yeah that condition should be removed. Do you want to submit a PR?

@gvkries
Copy link
Contributor Author

gvkries commented Dec 6, 2024

Alright, I can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants