Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Rule provider #17193

Open
ns8482e opened this issue Dec 9, 2024 · 4 comments
Open

Menu Rule provider #17193

ns8482e opened this issue Dec 9, 2024 · 4 comments
Milestone

Comments

@ns8482e
Copy link
Contributor

ns8482e commented Dec 9, 2024

Allow Site administrator to manage Admin menu according to their needs.

  • Provide a Menu Rule provider json file menu.json similar to the placement
  • Allow author to write rules to show/hide/position of the placement in the menu.json
  • Navigation provider - evaluate the menu rule before adding menu to the menu items.

This will allow site administrator to control menu items and their order without change in orchard core code base.

Ref
#17112 (comment)

@MikeAlhayek
Copy link
Member

I agree with this. It would be great to be able to use existing placements structure to define the position of each menu level/menu-item.

@sebastienros
Copy link
Member

Configuration then. Deployed with the app. Like placement. And optional, meaning it shouldn't make menus implementation harder, only for the people who don't like @MikeAlhayek 's menu.

@sebastienros sebastienros added this to the 2.x milestone Dec 12, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@ns8482e
Copy link
Contributor Author

ns8482e commented Dec 13, 2024

Configuration then. Deployed with the app. Like placement. And optional, meaning it shouldn't make menus implementation harder, only for the people who don't like @MikeAlhayek 's menu.

New structure is fine as long as it's applies to new sites, I personally prefer to have upgrade seamless, and new UI should be opt-in for existing sites and not other way around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants