-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.1.4 #17354
Comments
@kevinchalet, Today, we discussed updating OpenIddict in version 2.1.4, but after consideration, we believe it’s best not to include the update since the current version already comes with OpenIddict 5.7. OpenIddict 6 will be part of version 3. Are you comfortable with this approach? |
Not really, but what's decided is decided 🤣 |
Okay. So we are in the same page. I thought you wanted to upgrade OpenIddict in the patch. There is no plan for 2.2, so I would just release the patch so at least people have the latest fixes for 2.1 until we roll out 3.0. |
@MikeAlhayek Please include PR #17332 as requested: #17282 (comment) |
Done |
@MikeAlhayek is |
The |
The bug will occurs once we use a custom recipe |
Thanks @MikeAlhayek |
Which bug? The system roles are technical not required. |
@domonkosgabor please post about this on Facebook. Thanks you |
Release Patch Preparation Guide
Step 1: Backporting Pull Requests
main
branch that need to be applied to the release branch (e.g.,release/2.1
), comment on the merged PR with/backport to release/2.1
. This comment will trigger a GitHub Action to create a new PR with the same changes for therelease/2.1
branch.release/2.1
branch.Step 2: Code and Documentation Updates
Create Pull Request:
release/2.1
), create a new temporary branch for your release (e.g.,release-notes/2.1.1
).OrchardCore.Commons.props
: Set<VersionSuffix></VersionSuffix>
to the new version you're preparing for release.src/OrchardCore/OrchardCore.Abstractions/Modules/Manifest/ManifestConstants.cs
to reflect the new version.mkdocs.yml
navigation and remove it fromnot_in_nav
.Release 2.1.1
) from the documentation branch (e.g.,release-notes/2.1.1
) into the release branch (e.g.,release/2.1
)Preview - CI
workflow on your branch (NOTmain
). This will release a new preview version on CloudSmith for testing.Step 3: Validation
OrchardCore.Samples
to the latest preview version generated in the previous step. Ensure the samples work as expected.Step 4: Create New Release
v
(e.g.,v2.1.1
), and select "+ Create tag: v... on publish."main
to your target branch (e.g.,release/2.1
).2.1.1
).Step 5: Align Branches
main
contains all administrative changes.main
.main
into the release branch. Resolving conflicts using GitHub's interface will automatically mergemain
into the release branch, which must be avoided.main
using the following steps:main
branch.release/2.1
) intomain
.main
. This action requires a user with the ability to force-push intomain
, as it is protected by default.Step 6: Housekeeping
Step 7: Publicize the Release
The text was updated successfully, but these errors were encountered: