Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Improvement on InvariantGlobalization #17383

Closed
goh-chunlin opened this issue Jan 21, 2025 · 1 comment
Closed

Documentation Improvement on InvariantGlobalization #17383

goh-chunlin opened this issue Jan 21, 2025 · 1 comment

Comments

@goh-chunlin
Copy link
Contributor

Is your feature request related to a problem?

This is related to how Orchard Core will run into problem when new user of OC just follows exactly the Docker tutorial: https://docs.orchardcore.net/en/main/topics/docker/

This is related to the missing of InvariantGlobalization in the current csproj, as pointed out in this pull request "Add InvariantGlobalization to csproj #16873".

Describe the solution you'd like

Should we add a piece of information on the tutorial page telling the new users to remember to add the following to the csproj?

<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    ...
    <InvariantGlobalization>false</InvariantGlobalization>
  </PropertyGroup>

  ...

</Project>

Describe alternatives you've considered

This should not be needed once the pull request "Add InvariantGlobalization to csproj #16873" is approved.

@Piedone Piedone changed the title Documentation Improvement on Documentation Improvement on InvariantGlobalization Jan 21, 2025
@sebastienros
Copy link
Member

OC uses globalization features in .NET by default, so we can't change it by default. Our sample csproj should not disable it.

If you have the need to not install ICU packages, then you also need to set this property on your own csproj copy, or set it in other ways documented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants