Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema for recipe.json #1866

Open
xperiandri opened this issue May 28, 2018 · 9 comments
Open

Schema for recipe.json #1866

xperiandri opened this issue May 28, 2018 · 9 comments
Milestone

Comments

@xperiandri
Copy link
Contributor

Define a scheme for recipe.json to be make validation and statement completion work in Visual Studio

@xperiandri
Copy link
Contributor Author

@sebastienros, how and where is it consumed?

@Skrypt
Copy link
Contributor

Skrypt commented May 28, 2018

On Orchard Core setup you have 3 choices. SaaS, The Blog, The Agency. Those are 3 recipes coming from "Themes" that should be renamed "Templates" in the future.

@xperiandri
Copy link
Contributor Author

So I want to create my own theme.
If I create recipe.json for it, I don't know what can be present in it as no scheme for it available, nor Visual Studio can help or check me.

@Skrypt
Copy link
Contributor

Skrypt commented May 28, 2018

Well, I understand your request. We should probably use a JSON Schema file to parse this JSON file and return proper data validation messages.

@sebastienros sebastienros added this to the rc milestone May 31, 2018
@sebastienros
Copy link
Member

Creating a json schema is a very good idea.

@jasonshsoftware
Copy link

I agree with this. Here is my use case:

I'm working on a continuous delivery project in which content types and default content changes need to be consistent, repeatable and automated across multiple environments. Recipes are perfect for this.

In this case, I would be hand-crafting incremental recipes as the project progresses. These recipes would be executed in full (in the case of a new/rebuild environment) or only new (in the case of a point release). Exporting a recipe from the admin UI for me is not valuable since it will have all the previous changes that I will have to filter out by hand.

In the end, my options are hand-crafted recipes or a modification to the recipe export functionality that will give me a differential recipe. The latter is unlikely, so I'm fine with hand-crafting.

@sebastienros sebastienros modified the milestones: rc, 1.0 Aug 11, 2019
@agriffard
Copy link
Member

Closing, now that the recipe documentation is available.

@xperiandri
Copy link
Contributor Author

xperiandri commented Feb 9, 2020

Documentation ≠ JSON Scheme

@Skrypt Skrypt reopened this Feb 9, 2020
@sebastienros
Copy link
Member

I would suggest to integrate the generation of a global schema file by using the gulp script we are using. Each module would create it's own 'recipe' schema with a well-known filename. Then we can generate the global one in the root folder, and commit it to source code so we can reference it universally.

@sebastienros sebastienros modified the milestones: 1.0, 1.1 Apr 2, 2020
@sebastienros sebastienros modified the milestones: 1.1, 1.x Oct 7, 2021
@Piedone Piedone changed the title Scheme for recipe.json Schema for recipe.json Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants