Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Media File Store virtual methods #8005

Closed
deanmarcussen opened this issue Dec 15, 2020 · 1 comment · Fixed by #8006
Closed

Default Media File Store virtual methods #8005

deanmarcussen opened this issue Dec 15, 2020 · 1 comment · Fixed by #8006

Comments

@deanmarcussen
Copy link
Member

Recently I had to override one method on the DefaultMediaFileStore, which meant copying the entire code over, instead of inheriting, and tweaking the bit I needed.

Think it makes sense to make the methods virtual, to make changing the behaviour a little easier.

@hishamco
Copy link
Member

Does make all the methods virtual make sense? or there some of them that are really could be overriden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants