Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Notifications: Browser Push #806

Closed
micahalcorn opened this issue Oct 23, 2018 · 2 comments
Closed

Notifications: Browser Push #806

micahalcorn opened this issue Oct 23, 2018 · 2 comments

Comments

@micahalcorn
Copy link
Member

micahalcorn commented Oct 23, 2018

#795 is a proof-of-concept for implementing browser-based push notifications. This issue tracks the remaining concerns and to-do items.

Concern/Task Issue DApp Worker Server Database Other
the message strings #805 - - - -
storing and queueing events - - -
CORS rules - - - -
safeguarding against duplicates #875 - - ? -
localization of messages #808 ? ? ? -
including API keys - ? - -
integration with other webhooks - - ? ?
code formatting - ? - ?
documentation #810 - - - -
analytics #877 ? -
authentication for write endpoints -
retries ? - ? ?
consolidating multiple notifications - - - -
not displaying notifications when already focused - - - -
provide other click actions ? - - -
consequences of updates to sw.js ? ? ? ? -
bundling sw.js with React if appropriate ? ? - - -
caching (unrelated to notifications) ? ? - - -
not rendering modals on modals - - - -
prompting for notifications if not previously enabled - - - -
scoping subscriptions to ETH networks ? ? ?
displaying non-push notifications natively ? ? - - -
blocking/obscuring the UI during permission dialog - - - -
supporting configuration in settings ? ? -
tests
messaging-related notifications #1047
reminders for finalization, etc
subscription expiration
pushsubscriptionchange
validating account scope
Safari

Also, here is a lay of the land 😬
notifications 1

@micahalcorn
Copy link
Member Author

micahalcorn commented Mar 16, 2019

@franckc @joshfraser are we leaving this intact or scrapping it with the introduction of email notifications? Obviously, it's my baby, but I understand if we want to limit maintenance cost for lower-value features. 😢

@nick nick modified the milestone: Priority Issues Mar 19, 2019
@micahalcorn
Copy link
Member Author

Closing this until further notice ✝️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants