Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add ploceus version to mod jar manifest #1

Open
thecatcore opened this issue Jan 28, 2024 · 2 comments
Open

[Suggestion] Add ploceus version to mod jar manifest #1

thecatcore opened this issue Jan 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@thecatcore
Copy link

Add the ploceus version to the mod jar manifest as a way to recognize the mod as built with Ornithe intermediaries.
Or at least something that will differentiate/identify Ornithe mods.

It will come in handy the day we manage to get mods built with different intermediaries running together.

@SpaceWalkerRS
Copy link
Member

That's a good idea. I was thinking about this and we'll probably want to add something to our intermediary jar manifest as well, and copy that into the mod jar manifest after building.

haven't yet looked into that side of it, but does Loom provide an API for adding to the mod's jar manifest, or should Ploceus just hook into Gradle for that?

@SpaceWalkerRS SpaceWalkerRS added the enhancement New feature or request label Jan 28, 2024
@thecatcore
Copy link
Author

Loom doesn't seems to provide an API for it, but you can hook into AbstractRemapJarTask doLast and modify the jar manifest at this moment. That's what I've done in legacy-looming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants