Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various inputs around Layer Management should allow negative numbers #4

Closed
OtherworldBob opened this issue Mar 31, 2018 · 1 comment
Assignees
Labels
enhancement It kinda works...but it could be better.

Comments

@OtherworldBob
Copy link
Owner

Various inputs in Maniac around Layer Management are currently locked to only allow positive numbers.
This is due to the data types currently being used in the RSDKv5 project.

I believe at a minimum, UnknownWord (aka UnknownValue) 1 & 2, as part of the SceneLayer and ScrollInfo objects should be changed to Signed short values, and thus allow negative numbers. This should then filter up into Maniac itself.

In my testing, setting this values near the maximum for an unsigned short reverses their effects in-game: i.e. the layer starts scrolling in the opposite direction, compared to a value near 0.

@OtherworldBob OtherworldBob added the enhancement It kinda works...but it could be better. label Mar 31, 2018
@OtherworldBob OtherworldBob self-assigned this Mar 31, 2018
@OtherworldBob
Copy link
Owner Author

#13 Has been merged.
I haven't gone as far as renaming the internal RSDKv5 values yet, as I suppose there may be more knowledge to be mined yet. But I think everything else is still playing nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement It kinda works...but it could be better.
Projects
None yet
Development

No branches or pull requests

1 participant