Gnome 41 support #158

plumlis · 2021-09-23T14:23:54Z

It seems haven‘t gnome 41 ready yet？

plumlis · 2021-09-28T04:03:10Z

-- Journal begins at Mon 2021-05-10 13:40:14 CST. --
9月 28 11:54:19 plum-laptop gnome-shell[4977]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
9月 28 11:54:19 plum-laptop gnome-shell[4977]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
9月 28 11:57:43 plum-laptop gnome-shell[4977]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
9月 28 11:57:55 plum-laptop gnome-shell[4977]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
9月 28 11:57:55 plum-laptop gnome-shell[4977]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
9月 28 11:58:56 plum-laptop gnome-shell[4977]: Timelines with detached actors are not supported
9月 28 11:59:04 plum-laptop gnome-shell[4977]: JS ERROR: Error: cmd: gjs /home/plum/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/auxhelper.js --filename /tmp/gnome-shell-screenshot-0B2DA1.png --area 1048,161,378,262 exitCode=256
spawnAsync/</<@/home/plum/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/extension.js:469:30
9月 28 11:59:17 plum-laptop gnome-shell[4977]: Timelines with detached actors are not supported
9月 28 11:59:17 plum-laptop gnome-shell[4977]: Timelines with detached actors are not supported
9月 28 12:00:56 plum-laptop gnome-shell[4977]: JS ERROR: Error: cmd: gjs /home/plum/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/auxhelper.js --filename /tmp/gnome-shell-screenshot-W9ZVA1.png --area 424,640,527,236 exitCode=256
spawnAsync/</<@/home/plum/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/extension.js:469:30

saboya · 2021-10-16T01:54:18Z

In their infinite wisdom the Gnome team decided to just break userspace abruptly:

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1970

Essentially this extension has to be reimplemented using org.freedesktop.portal.Screenshot, but unclear if it can have feature parity with the existing functionality.

The alternative is using unsafe mode, which you can do by using this:

https://extensions.gnome.org/extension/4517/unsafe-mode/

OttoAllmendinger · 2021-10-16T09:48:19Z

Thanks for the heads up. Looks like it won't be an easy change.

ramottamado · 2021-10-17T07:05:59Z

In their infinite wisdom the Gnome team decided to just break userspace abruptly:

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1970

Essentially this extension has to be reimplemented using org.freedesktop.portal.Screenshot, but unclear if it can have feature parity with the existing functionality.

The alternative is using unsafe mode, which you can do by using this:

https://extensions.gnome.org/extension/4517/unsafe-mode/

Hello, I'm the author of said extension. Basically, that extension works by enabling unsafe_mode from Mutter global context (which you can always do from LG or from your own extension, just see the source code itself).

The problem is this mode is (surprise!) unsafe for end users, since this enable arbitrary code executions (just like ol' GNOME 3 days) by abusing Eval() dbus method.

Since security is a big issue, and nobody wants some rogue apps, scripts or extensions running malicious codes on their machine because an extension just open up the possibility to, I've since inactivated the extension, but you can still install the extension from the source code.

So you can either:

Enable unsafe_mode from your extension (which is not advised, and potentially a security breach)
Register your DBus caller as n allowed caller on the Shell side from your extension
Re-implement the caller

stefangweichinger · 2021-10-21T15:17:38Z

Is there a usable workaround for Gnome 41 now, or not? I just upgraded to Fedora 35 beta and find myself without this very useful extension ;-) thanks for any info on that

saboya · 2021-10-21T18:35:16Z

@stefangweichinger Since you're using Fedora 35, you might as well use this:

https://copr.fedorainfracloud.org/coprs/yalter/gnome-shell-screenshot-ui/

It has a new "native" screenshot ui that will probably be enough for most people. I'm using that for now.

stefangweichinger · 2021-10-21T19:06:16Z

@saboya thanks. "Everybody else should avoid this repo." sound good ;-)

rduivenvoorde · 2021-10-23T10:45:07Z

Mmm, really miss this extension.

I had a look now at the 'Default Gnome Screenshot tool', and was actually rather positive about it's capabilities:

Only thing I miss is your nice 'menu' item...

So I wonder (and that would be my question) if it would be doable to 'merge' your menu with the workings of the screenshot tool?
OR is this actually already what you did?
OR would it be more appropriate to make this a feature request in the Screenshot Tool repo: "plz make it possible to (optionally) add a menu to the topbar"

OttoAllmendinger · 2021-10-25T08:43:11Z

for those who can't wait any longer, I pushed this branch here https://github.com/OttoAllmendinger/gnome-shell-screenshot/tree/gnome41-unsafe-mode

moore-bryan · 2021-11-06T12:01:45Z

Sorry, @OttoAllmendinger, the above "unsafe" fix doesn't work for me; i.e., same Error exit code=256 issue on my Fedora 35 install.

BlackDex · 2021-11-11T15:11:44Z

@moore-bryan that is because there is an error in the code. In his hast @OttoAllmendinger forgot to add , after the "40" versions while adding "41".

I applied these changes manually within my ~/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de directory to the same files. And at line 1289 of the extension.js i add the following:

global.context.unsafe_mode = true;

Reloaded Gnome-Shell and now it is working like a charm again.

rduivenvoorde · 2021-11-11T17:38:38Z

@BlackDex are you sure about the comma? It is already an array?

I checked out the gnome41-unsafe-mode and did the install as written in readme and extension is working here (Debian testing). No comma needed, both with (an optional) and without it works.

Only change I see is the 'broken lock' icon, probably because it is 'unsafe'?

BlackDex · 2021-11-11T19:33:13Z

@rduivenvoorde , normally javascript array's need a , to separate the array elements.
But, i'm not sure regarding gnome-shell actually, could be different.

Could be that it is causing issues now, but maybe no critical items. Also since the metadata just has one element, which is no issue there.

moore-bryan · 2021-11-11T21:53:39Z

Well, the comma is irrelevant for me because I'd already adjusted the metadata.json file to include the correct version and adding the code at line 1289 breaks everything; that is, without it, the icon will load but I can't screenshot and with it the extension cannot be enabled at all.

jmrodri · 2021-11-13T22:30:36Z

Is there a usable workaround for Gnome 41 now, or not? I just upgraded to Fedora 35 beta and find myself without this very useful extension ;-) thanks for any info on that

I'm having the same problem now. I should've known this is my most used extension.

lvanderree · 2021-11-19T08:02:53Z

@BlackDex are you sure about the comma? It is already an array?

I checked out the gnome41-unsafe-mode and did the install as written in readme and extension is working here (Debian testing). No comma needed, both with (an optional) and without it works.

Only change I see is the 'broken lock' icon, probably because it is 'unsafe'?

That is correct. I was also wondering what this icon was...
https://discourse.gnome.org/t/what-does-the-lock-icon-mean/8040

lvanderree · 2021-11-19T08:04:31Z

My workaround is to have the PrtSc-key bounded to the gnome-screenshot-tool. Which sort of works OK,
but I would rather still use this extension.

fhuberts · 2021-11-21T12:27:12Z

I'm on Fedora 35, and it has these shortcuts:

I think switching to the new shortcuts is doable, I'm going to try :-)

somepaulo · 2021-11-25T16:18:26Z

I think switching to the new shortcuts is doable, I'm going to try :-)

The trouble of memorizing all those shortcuts, especially when you only need screenshots once in a while, was most people's reason for using this extension (imho). No need to remember, just use the convenient menu.

OttoAllmendinger · 2021-11-28T13:23:02Z

portal support: #168

OttoAllmendinger · 2021-11-29T10:16:59Z

Version with Gnome 41 support is now active in the store.

saboya mentioned this issue Oct 16, 2021

Cannot take screenshot on gnome 41 + wayland flameshot-org/flameshot#1910

Closed

diwakargoel mentioned this issue Nov 18, 2021

Incompatible with Gnome 41 #165

Closed

OttoAllmendinger changed the title ~~Gnome 41 support？~~ Gnome 41 support Nov 28, 2021

This was referenced Nov 28, 2021

TypeError this.gtkImage.pixbuf is null #166

Closed

Error: exitcode=356 #169

Closed

OttoAllmendinger closed this as completed Nov 29, 2021

netroy mentioned this issue Dec 1, 2021

Doesn't work with Gnome 41 - even after update to Screenshot Tool v61 #171

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gnome 41 support #158

Gnome 41 support #158

plumlis commented Sep 23, 2021

plumlis commented Sep 28, 2021

saboya commented Oct 16, 2021

OttoAllmendinger commented Oct 16, 2021

ramottamado commented Oct 17, 2021

stefangweichinger commented Oct 21, 2021

saboya commented Oct 21, 2021

stefangweichinger commented Oct 21, 2021

rduivenvoorde commented Oct 23, 2021

OttoAllmendinger commented Oct 25, 2021

moore-bryan commented Nov 6, 2021

BlackDex commented Nov 11, 2021

rduivenvoorde commented Nov 11, 2021

BlackDex commented Nov 11, 2021

moore-bryan commented Nov 11, 2021 •

edited

Loading

jmrodri commented Nov 13, 2021

lvanderree commented Nov 19, 2021

lvanderree commented Nov 19, 2021

fhuberts commented Nov 21, 2021

somepaulo commented Nov 25, 2021

OttoAllmendinger commented Nov 28, 2021

OttoAllmendinger commented Nov 29, 2021

Gnome 41 support #158

Gnome 41 support #158

Comments

plumlis commented Sep 23, 2021

plumlis commented Sep 28, 2021

saboya commented Oct 16, 2021

OttoAllmendinger commented Oct 16, 2021

ramottamado commented Oct 17, 2021

stefangweichinger commented Oct 21, 2021

saboya commented Oct 21, 2021

stefangweichinger commented Oct 21, 2021

rduivenvoorde commented Oct 23, 2021

OttoAllmendinger commented Oct 25, 2021

moore-bryan commented Nov 6, 2021

BlackDex commented Nov 11, 2021

rduivenvoorde commented Nov 11, 2021

BlackDex commented Nov 11, 2021

moore-bryan commented Nov 11, 2021 • edited Loading

jmrodri commented Nov 13, 2021

lvanderree commented Nov 19, 2021

lvanderree commented Nov 19, 2021

fhuberts commented Nov 21, 2021

somepaulo commented Nov 25, 2021

OttoAllmendinger commented Nov 28, 2021

OttoAllmendinger commented Nov 29, 2021

moore-bryan commented Nov 11, 2021 •

edited

Loading