Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cf-encoding workaround #73

Open
aulemahal opened this issue Aug 20, 2024 · 0 comments
Open

Remove cf-encoding workaround #73

aulemahal opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
priority Immediate action required

Comments

@aulemahal
Copy link
Contributor

The encoding of cftime coordinates within sdba's map_blocks could be removed as the upstream issue in xarray seems to be fixed : pydata/xarray#5701. I don't know how it got fixed, but I believe the snippet below (and some other) and the xclim options can be safely removed. Or I guess the option should stay for 1 or 2 versions and emit a warning.

https://github.com/Ouranosinc/xclim/blob/7acc410dc34f878ace5230b3e34ed4eee25dae03/xclim/sdba/base.py#L675-L683

FYI for xsdba, @coxipi

@aulemahal aulemahal self-assigned this Aug 20, 2024
@Zeitsperre Zeitsperre added the priority Immediate action required label Dec 10, 2024
@Zeitsperre Zeitsperre transferred this issue from Ouranosinc/xclim Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Immediate action required
Projects
Status: No status
Development

No branches or pull requests

2 participants