Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make catalog.py, config.py and io.py their own package #153

Closed
1 task
RondeauG opened this issue Feb 9, 2023 · 5 comments
Closed
1 task

Make catalog.py, config.py and io.py their own package #153

RondeauG opened this issue Feb 9, 2023 · 5 comments
Labels
wontfix This will not be worked on

Comments

@RondeauG
Copy link
Collaborator

RondeauG commented Feb 9, 2023

Addressing a Problem?

These 3 scripts do a lot of useful things that go beyong xscen. They ould be moved to their own repo/package, and simply be imported by xscen.

Potential Solution

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.
@RondeauG RondeauG added the enhancement New feature or request label Feb 9, 2023
@RondeauG RondeauG added this to the 2023 Development Plan milestone Feb 9, 2023
@RondeauG
Copy link
Collaborator Author

Or not... Compare to functions in miranda and assess who copies who and which ones should be merged.

@Zeitsperre
Copy link
Contributor

I still don't think it's a terrible idea to make these into a helper package. This is a pretty standard approach for libraries that produced by the same organization (e.g. https://github.com/roocs/roocs-utils).

We wouldn't be the first to consider doing this either...

@RondeauG
Copy link
Collaborator Author

RondeauG commented May 31, 2023

Following our discussions last week and here, this issue can be closed.

  • miranda keeps:

    • Downloads and APIs
    • convert
    • validation (CV, facets)
    • frequency & xrfreq dictionnaries
  • xscen keeps:

    • IO, config, scripting
    • frequency & xrfreq dictionnaries
  • xscen gains those from miranda:

    • structure: Building the Ouranos folder structure based on facets
    • decode: To be replaced by a ‘parse_directory’ workflow

The specific workflows (e.g. download ERA5, convert and validate, then move the files to the correct folder structure) will move to a private repo.

@Zeitsperre
Copy link
Contributor

It might be worthwhile to create a "project" under xscen and open issues in the affected repositories, associating them to the project.

@RondeauG RondeauG added wontfix This will not be worked on and removed enhancement New feature or request labels Aug 30, 2023
@Zeitsperre
Copy link
Contributor

Issues are now listed on miranda side. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Development

No branches or pull requests

2 participants