Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flask to >=2.0 to support python 3.10 and further release #201

Open
matbgn opened this issue Mar 1, 2022 · 2 comments
Open

Upgrade flask to >=2.0 to support python 3.10 and further release #201

matbgn opened this issue Mar 1, 2022 · 2 comments

Comments

@matbgn
Copy link

matbgn commented Mar 1, 2022

Describe the feature you'd like
Upgrade flask to >=2.0 for python 3.10 compatibility. Not possible to run Kanmail with python 3.10 and more for future release.

Additional context
Flask depreciation

from collections import MutableMapping
:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working

if you update the flask package to >=2.0 it will import it correctly also in python 3.10

@matbgn
Copy link
Author

matbgn commented Mar 31, 2022

I see that you're busy with projects' issues, maybe you could give me some hints to do the job for this issue as well.

What will be the corner cases to take care of when upgrading flask for Kanmail? Any other valuable advice as well?

@Fizzadar
Copy link
Member

Thank you @matbgn, really appreciate you looking into these!

Flask wise - I can't think of anything that would cause problems, the usage of flask is pretty standard in Kanmail.

Python wise it's always pyinstaller that limits the version support, but 3.10 support is completed so this shouldn't present any issues either, so I think it should be a simple upgrade :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants