Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (& improve) repetition options #29

Closed
1 task done
Glitchy-Tozier opened this issue Jul 17, 2021 · 7 comments
Closed
1 task done

Fix (& improve) repetition options #29

Glitchy-Tozier opened this issue Jul 17, 2021 · 7 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Glitchy-Tozier
Copy link

Describe the bug:

This option (look at the left) probably does, what it should. It jumps to the next song when the current one is finished. The symbol is debatable, but otherwise it works fine:
Screenshot_20210717-070933_Auxio.jpg


This symbol ALSO doesn't loop the song. It seems to work just as the first one does:
Screenshot_20210717-071013_Auxio.jpg


This symbol loops the song forever (or at least 3 times) instead of just once.
Screenshot_20210717-071024_Auxio.jpg


Sometimes people don't want to binge through their music, but instead only listen to one track and then have the playing stop until they want to listen to the next track. It can be annoying to immediately be bombarded with a different song.
I suggest adding an option that lets the user play a song, and then pauses (and rewinds) the song when it's done playing.

Screenshots:

Screenshot_20210717-072414_Auxio.jpg

Phone Information:

Samsung Galaxy S9
Android 10

Due Diligence:

@Glitchy-Tozier Glitchy-Tozier added the bug Something isn't working label Jul 17, 2021
@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jul 17, 2021

Oh. After #13, Auxio's repeat modes are none, loop playlist, and loop forever. The second one didn't do anything since it would only repeat the playlist once it ended. If I understand correctly, you want the "Loop Forever" option to pause the song every time it loops? If that's the case, I can add a toggle for that behavior in the settings menu.

@Glitchy-Tozier
Copy link
Author

Glitchy-Tozier commented Jul 17, 2021

  1. Yes, It would be great to see another option that rewinds and pauses the song after it's done.
  2. regarding the rest of your message, I'm not sure I fully understand your comment.
    Is there a difference between [black] and [blue]? (Let's call the third option "[blue 1]")

@OxygenCobalt
Copy link
Owner

Basically:

[black] - Loop the playlist, but pause when it loops
[blue] - Loop the playlist, continuing playback when it loops
[blue 1] - Loop the song forever.

I'll add an option to the "Behavior" part of the settings menu that toggles this change. It will still be represented as [loop 1], but instead of playing immediately after looping, it will just rewind and pause, like you said.

@Glitchy-Tozier
Copy link
Author

Thank you for the explanation. The change you described sounds great, looking forward to using it! :)

@Glitchy-Tozier
Copy link
Author

It could also be added as one of the regular options (it could be a pause icon or a pause icon inside the arrows), but if you prefer using the settings, that's fine too.

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jul 17, 2021

I usually choose the settings for two reasons:

  1. Your preferred loop behavior tends to apply to a subset of users. I prefer keeping Auxio sensible by default and moving the quirks to the behavior menu, so thats where behavior additions tend to go. If theres sufficient demand for a dedicated mode for this specific behavior, it would likely be upgraded to one [as is what happened in Change loop playback functionality? #13].
  2. There's not a ready-made icon for such a mode, meaning that I would have to create my own. Not impossible [I did it with the sorting icons], but hard.

@Glitchy-Tozier
Copy link
Author

Understood, lets go the settings-route then!

@OxygenCobalt OxygenCobalt added the enhancement New feature or request label Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants