Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exlude directories from indexing #6

Closed
Miaourt opened this issue Mar 2, 2021 · 5 comments
Closed

Exlude directories from indexing #6

Miaourt opened this issue Mar 2, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@Miaourt
Copy link

Miaourt commented Mar 2, 2021

Hello, thanks for this app !
I think being able to have a denylist of directories (or maybe an allowlist ?) that are indexed in the app would be interesting !

I'm indeed working with audio files sometime, downloading podcasts too, and I don't want them in the music player app :)

I think this shouldn't bloat the app much, if you take the allowlist path you could simply put the default ~/music folder for example, and if you take the denylist path a simple list of excluded folder would be simple enough to understand I guess 😅

[ x ] I have read Accepted Additions and Requests and the Contribution Guidelines.

@Miaourt Miaourt added the enhancement New feature or request label Mar 2, 2021
@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Mar 3, 2021

This would benefit my own usage, and it seems to be a reasonable addition to the codebase. I'll implement it.

The caveat here is that it would elongate the loading times, since I would have to now load a database of the blocked directories and cross-reference them with the loaded music items. I may study how Phonograph implements the same enhancement and try to implement it in my own system efficiently.

Thanks for the suggestion!

@OxygenCobalt
Copy link
Owner

The feature has been finished and will be released in 1.3.2 today. Thank you for this suggestion.

@voussoir
Copy link

voussoir commented Mar 15, 2022

Hi @OxygenCobalt, it seems that Auxio excludes the ~/Podcasts folder unconditionally, is that correct? When I rename ~/Podcasts to anything else, the files appear in Auxio, and when I rename it back they disappear. I can't find any use of the word podcasts in the source code so maybe this is a decision by the android mediaserver.

I was actually hoping to use Auxio just for my podcast files!

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Mar 15, 2022

@voussoir I believe this is intentional. Auxio uses the IS_MUSIC=1 selector when indexing audio files so that certain audio (like ringtones) aren't indexed. By extension, anything in the Podcasts folder will not be labeled as music and Auxio excludes them. I might be able to get rid of this and replace it with a predefined set of excluded directories, but I have no idea how effective that would be.

@voussoir
Copy link

@OxygenCobalt That makes sense, thanks! It's okay, I can just rename the folder. I didn't know android's media framework made that distinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants