Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist not sorting properly - Seems to be caused by ALBUMSORT tags #760

Closed
4 tasks done
bryanparadis opened this issue Apr 22, 2024 · 9 comments
Closed
4 tasks done
Assignees
Labels
bug Something isn't working critical Need to get this fixed right now music Related to music loading

Comments

@bryanparadis
Copy link

Describe the Bug/Crash

You can see that Katatonia and Shlohmo are both in the D section. Shlohmo has extended artistsort field in tag but it is set to Shlohmo. Katatonia has extended artistsort field in tag but it is set to Katatonia. I saw a previous issue where this extended field had some other value in it but this isn't the case here. Everything has been manually tagged with mp3tag.

Looking further it seems like it's to do with m4a files from itunes which do have sort tags. After looking at about 5-6 examples I can confidently say that it is because the artists have an album that begins with that letter so it's related to the ALBUMSORT tag.

Describe the intended behavior

Should actually sort by Name Ascending.

What android version do you use?

Android 13

What device model do you use?

Fairphone 4

Provide a sample file

Can provide privately if actually needed.

Bug report

Can provide if actually needed.

Duplicates

@bryanparadis bryanparadis added the bug Something isn't working label Apr 22, 2024
@bryanparadis
Copy link
Author

bryanparadis commented Apr 22, 2024

I edited one of the Vitalism track's ALBUMSORT tags and changed it to "0testing" to see if I could get it to appear at the top of the Artist list and it did.

@bryanparadis
Copy link
Author

bryanparadis commented Apr 22, 2024

Could not reproduce with a MP3 by adding albumsort to the tag and rescanning library. Seems to do with MP4/M4A and albumsort specifically. I had a look through the source for TSOA/soal/albumsort/artistsort but couldn't find any smoking gun. Removing the albumsort field from the mp4 tag fixes the issue.

@bryanparadis
Copy link
Author

bryanparadis commented Apr 22, 2024

Saw that you were using androidx.media3.exoplayer.MetadataRetriever so I thought I would take a quick look at the Android source and found someting interesting. Those seem all rather mixed up. It's 2am but I rechecked a few times.

Opened an issue over there:

androidx/media#1302

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Apr 22, 2024

Huh, I thought this would be another "I don't realize I have sort tags" issue, but instead it's a legit media3 bug. For now I can patch this myself easily since I vendor media3. Can I have a sample file @bryanparadis? Just e-mail me one w/no copyrighted audio.

@OxygenCobalt OxygenCobalt added music Related to music loading critical Need to get this fixed right now labels Apr 22, 2024
@bryanparadis
Copy link
Author

Huh, I thought this would be another "I don't realize I have sort tags" issue, but instead it's a legit media3 bug. For now I can patch this myself easily since I vendor media3.

Glad I could surprise you! Haha. Funnily enough finding bugs in third parties is kind of my thing.

Can I have a sample file @bryanparadis? Just e-mail me one w/no copyrighted audio.

Sent a couple your way

@bryanparadis
Copy link
Author

@OxygenCobalt A fix commit already upstream!

@OxygenCobalt
Copy link
Owner

Okay, I'll cherry-pick it when I get the chance @bryanparadis. Thanks for reporting this!

@bryanparadis
Copy link
Author

Okay, I'll cherry-pick it when I get the chance @bryanparadis. Thanks for reporting this!

Glad I was able to contribute. Cheers

@bryanparadis
Copy link
Author

Got the 3.5.0 update installed and after a quick check artists seem to be in expected order now. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Need to get this fixed right now music Related to music loading
Projects
Archived in project
Development

No branches or pull requests

2 participants