Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used toned-down black themes #961

Open
4 tasks done
hknutsen opened this issue Jan 14, 2025 · 2 comments
Open
4 tasks done

Used toned-down black themes #961

hknutsen opened this issue Jan 14, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request ui Related to app UI

Comments

@hknutsen
Copy link

hknutsen commented Jan 14, 2025

Description

After upgrading to 4.0.0-dev3, I no longer get a pure-black background on the "Now playing" screen when the pure-black theme is enabled.

Library screen with pure-black theme enabled:

Library screen with pure-black theme enabled

"Now playing" screen with pure-black theme enabled (background is not pure-black):

"Now playing" screen with pure-black theme enabled

Library screen background color vs "Now playing" screen background color:

Background colors comparison

Evidence that pure-black theme ("Svart drakt" in Norwegian) is enabled:

bilde

Problem solved

No response

Other implementations

Other music players (Poweramp, Retro Music Player, Oto Music) enable a pure-black background on the "Now playing" screen when the pure-black theme (or their equivalent feature) is enabled.

Benefit

Improves visual consistency when pure-black theme is enabled.

Duplicates

@hknutsen hknutsen added the enhancement New feature or request label Jan 14, 2025
@Richard38907
Copy link

Same here, please re-add pure black player when "pure black" option is set to on.

@OxygenCobalt
Copy link
Owner

The new M3 guidelines require the use of these elevated colors, so the most I can do is tone them down. That requires me to regenerate most of my themes, I think. Will look into this, probably won't be 4.0.0.

@OxygenCobalt OxygenCobalt changed the title Use pure-black theme on "Now playing" screen in 4.0.0 Used toned-down black themes Jan 15, 2025
@OxygenCobalt OxygenCobalt added the ui Related to app UI label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Related to app UI
Projects
None yet
Development

No branches or pull requests

3 participants