Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete returns true when it has failed #12

Open
jamieburchell opened this issue Jul 13, 2015 · 0 comments
Open

Delete returns true when it has failed #12

jamieburchell opened this issue Jul 13, 2015 · 0 comments

Comments

@jamieburchell
Copy link
Collaborator

When deleting a database row the delete function returns true even if it failed. There doesn't seem to be any checking of the result of the delete and returns true/commits transaction regardless.

// Delete the object itself
$this->db->where('id', $this->id);
$this->db->delete($this->table);

// Complete auto transaction
$this->_auto_trans_complete('delete');

// Clear this object
$this->clear();

return TRUE;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant