Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monsoon sperber: add landsea mask estimation if not given #710

Closed
lee1043 opened this issue Mar 17, 2021 · 2 comments · Fixed by #1022
Closed

Monsoon sperber: add landsea mask estimation if not given #710

lee1043 opened this issue Mar 17, 2021 · 2 comments · Fixed by #1022

Comments

@lee1043
Copy link
Contributor

lee1043 commented Mar 17, 2021 •
edited
Loading

Currently monsoon sperber requires landsea mask to given in separate file for each of observation and models. However, considering land sea mask is not always available, estimation capability needs to be added, as it was done for modes of variability codes:

pcmdi_metrics/pcmdi_metrics/variability_mode/lib/landmask.py

Line 66 in 20d332e

def estimate_landmask(d):

Thanks @acordonez for bringing this to the table.
@lee1043 lee1043 mentioned this issue Mar 23, 2021
Closed
2 tasks
@lee1043
Copy link
Contributor Author

lee1043 commented Mar 23, 2021

Issue merged to #713

@lee1043 lee1043 closed this as completed Mar 23, 2021
@lee1043
Copy link
Contributor Author

lee1043 commented Mar 7, 2023

Closed #713 and reopen this.

@lee1043 lee1043 reopened this Mar 7, 2023
@lee1043 lee1043 mentioned this issue Apr 24, 2023
Closed
@lee1043 lee1043 linked a pull request May 17, 2024 that will close this issue
New monsoon sperber code in xCDAT -- PR cleaned up #1022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New monsoon sperber code in xCDAT -- PR cleaned up PCMDI/pcmdi_metrics
1 participant
@lee1043