Minor bug in r.abin

[JanPolena]

I found a minor bur in r.abin file, specifically lines 13 and 14:

#$ -cwd -notify
#$ -q kq-32-8 -pe shm 1

#$ is read by Unix systems as a "command" similary to #! when writing #!/bin/bash instead of comment line.

I would recommend changing to:

# #$ -cwd -notify
# #$ -q kq-32-8 -pe shm 1

[JanPolena]

Hello @danielhollas,

I found a minor bug and suggested a quick fix.

Regarding the error message:
After sending the simulation on the PHOTOX Krypton node using

qsub -q nodename -cwd -V r.abin,

server's response was:

error: executing task of job 277064 failed: execution daemon on host "k02.vscht.cz" didn't accept task

Best regards,
Jan

[danielhollas]

@JanPolena thank you for the report! 👋

#$ is read by Unix systems as a "command" similary to #! when writing #!/bin/bash instead of comment line.

#$ is actually a syntax specific to the SGE scheduler that's used on Prague clusters. Instead of passing parameters on command line, one can specify them in the script itself.

I agree that we shouldn't include the queue name in the script. I do want to keep the #$ -cwd -notify line. -cwd is afaik always needed. -notify is a somewhat obscure option that is needed so that when you issue the qdel command, the queuing system issues a SIGUSR2 signal to the script, which can then handle it. We use it here:

ABIN/utils/r.abin

Line 139 in a781b39

trap copy_from_scrdir EXIT SIGUSR2

I've made some changes in #191, if you could take a look that would be great!