Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with "ignore_state" not working with Baeck-An couplings #198

Closed
jack-t-taylor opened this issue Dec 9, 2024 · 1 comment · Fixed by #197
Closed

Problem with "ignore_state" not working with Baeck-An couplings #198

jack-t-taylor opened this issue Dec 9, 2024 · 1 comment · Fixed by #197
Assignees
Labels

Comments

@jack-t-taylor
Copy link

The keyword ignore_state is currently not correctly functional for couplings='baeck-an'.

This is a problem seen for protonated formaldimine XMS-CASPT2 FSSH/Baeck-An dynamics considering 3 states (S0, S1 and S2) within the state-averaging, but only two states (S0 and S1) in the dynamics.

It leads to probabilities for hopping to (and populations for) S2 (i.e., state 3) being non-zero at certain points along the trajectory, which is incorrect.

As a result, most trajectories show frustrated hops when hopping to S2 is erroneously attempted. However, certain trajectories also fail with the following error reported in the abin.out output file:

error_in_abin out

As suggested by @JanosJiri, this latter problem could be due to BAGEL not calculating S2 gradients (due to the ignore_state keyword being partially enacted), despite ABIN wanting them as it attempts to hop to S2 at certain points along the trajectory.

@JanosJiri JanosJiri added the bug label Dec 10, 2024
@JanosJiri JanosJiri self-assigned this Dec 10, 2024
@JanosJiri JanosJiri linked a pull request Dec 10, 2024 that will close this issue
@JanosJiri
Copy link
Contributor

Cool, thanks for reporting it @jack-t-taylor. It should be a simple fix. I created a new PR #197 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants