Tests/PHPCSVersions: bug fix

The PHP native `min()` and `max()` versions were used to retrieve the lowest/highest PHPCS version from arrays of PHPCS versions.

This worked fine at the time this class was created as none of the supported PHPCS versions had a `*.10` minor (or higher) at the time.

However, this logic was broken as soon as the `3.10.0` release was tagged - see https://3v4l.org/XbHOY - , we just never realized until now.

Fixed now by adding custom `min`/`max` methods to the class.

Author: jrfnl

tests/PHPCSVersions.php

@@ -153,8 +153,8 @@ public static function getHighLow($addMaster = false, $addNextMajor = false)
         $selection = array();
 
         if (empty($versions) === false) {
-            $selection[] = min($versions);
-            $selection[] = max($versions);
+            $selection[] = self::min($versions);
+            $selection[] = self::max($versions);
         }
 
         if ($addMaster === true && self::isDevSupported()) {
@@ -205,13 +205,13 @@ static function ($v) {
 
         $selection = array();
         if (empty($versions3) === false) {
-            $selection[] = min($versions3);
-            $selection[] = max($versions3);
+            $selection[] = self::min($versions3);
+            $selection[] = self::max($versions3);
         }
 
         if (empty($versions4) === false) {
-            $selection[] = min($versions4);
-            $selection[] = max($versions4);
+            $selection[] = self::min($versions4);
+            $selection[] = self::max($versions4);
         }
 
         if ($addMaster === true && self::isDevSupported()) {
@@ -225,6 +225,50 @@ static function ($v) {
         return $selection;
     }
 
+    /**
+     * Find the lowest version in an array of PHPCS versions.
+     *
+     * @param array<string> List of PHPCS version identifiers.
+     *
+     * @return string The version identifier of the lowest PHPCS version in the list.
+     */
+    public static function min($versions)
+    {
+        return array_reduce(
+            $versions,
+            static function ($carry, $item) {
+                if ($carry === null) {
+                    // First iteration.
+                    return $item;
+                }
+
+                return version_compare($carry, $item, '<') ? $carry : $item;
+            }
+        );
+    }
+
+    /**
+     * Find the highest version in an array of PHPCS versions.
+     *
+     * @param array<string> List of PHPCS version identifiers.
+     *
+     * @return string The version identifier of the highest PHPCS version in the list.
+     */
+    public static function max($versions)
+    {
+        return array_reduce(
+            $versions,
+            static function ($carry, $item) {
+                if ($carry === null) {
+                    // First iteration.
+                    return $item;
+                }
+
+                return version_compare($carry, $item, '>') ? $carry : $item;
+            }
+        );
+    }
+
     /**
      * Get a random PHPCS version which is valid for the current PHP version.
      *