Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Old versions do not exit, leaves a thread with no purpose #66

Closed
UnforeseenOcean opened this issue Aug 7, 2023 · 1 comment · Fixed by #68
Closed

Bug: Old versions do not exit, leaves a thread with no purpose #66

UnforeseenOcean opened this issue Aug 7, 2023 · 1 comment · Fixed by #68
Assignees
Labels
bug Something isn't working
Milestone

Comments

@UnforeseenOcean
Copy link

Symptom: When a new version is detected, the old version does not exit. Instead, it spawns a message box saying a new version is available, and if it's closed, leaves a functionless and useless thread in the process list.
Either allowing the old versions to work or exiting the thread when the message is closed will solve the issue.

@Brollyy
Copy link
Collaborator

Brollyy commented Aug 7, 2023

I've known about this bug from Watsu, but forgot to file it in, thanks @UnforeseenOcean!

I can fix this in the new versions going forward, but not sure about going back and hotfixing all of the previous releases...

At least there's a known workaround for this issue: go to the Settings on the newest version and disable "Check for Updates" flag. This will then cause the old version to skip the check as well and launch correctly.

@Brollyy Brollyy added the bug Something isn't working label Aug 7, 2023
@Brollyy Brollyy added this to the 1.2.2 milestone Aug 7, 2023
@Brollyy Brollyy self-assigned this Aug 7, 2023
@Brollyy Brollyy linked a pull request Aug 7, 2023 that will close this issue
@PKBeam PKBeam closed this as completed in #68 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants