Linker for Windows (#538)

* Add a linker option to trigger a custom linker (for example clang or cc as linker/driver)

* Use tempfile while compiling

* Change the path of the called command, still fails on windows
* windows linker finds libs in build directory

Co-authored-by: Ghaith Hachem <ghaith.hachem@bachmann.info>

Author: flavioBachmann

Cargo.lock

@@ -32,6 +32,8 @@ serde_json = "1"
 toml = "0.5"
 lazy_static = "1.4.0"
 shell-words = "1.1.0"
+which = "4.2.5"
+tempfile = "3"
 
 [dev-dependencies]
 num = "0.4"

Cargo.toml

@@ -1,6 +1,4 @@
 use crate::diagnostics::Diagnostic;
-use crate::diagnostics::ErrNo;
-use crate::make_absolute;
 use crate::resolve_environment_variables;
 use crate::FormatOption;
 use serde::{Deserialize, Serialize};
@@ -40,17 +38,21 @@ impl Project {
             files: self
                 .files
                 .into_iter()
-                .map(|it| make_absolute(&it, root))
+                .map(|it| if it.is_absolute() { it } else { root.join(it) })
                 .collect(),
             libraries: self
                 .libraries
                 .into_iter()
                 .map(|it| Libraries {
-                    path: make_absolute(&it.path, root),
+                    path: if it.path.is_absolute() {
+                        it.path
+                    } else {
+                        root.join(it.path)
+                    },
                     include_path: it
                         .include_path
                         .into_iter()
-                        .map(|it| make_absolute(&it, root))
+                        .map(|it| if it.is_absolute() { it } else { root.join(it) })
                         .collect(),
                     ..it
                 })
@@ -67,34 +69,16 @@ impl Project {
     }
 }
 
-pub fn get_project_from_file(build_config: &Path, root: &Path) -> Result<Project, Diagnostic> {
+pub fn get_project_from_file(build_config: &Path) -> Result<Project, Diagnostic> {
     //read from file
     let content = fs::read_to_string(build_config)?;
 
     //convert file to Object
     let project = Project::try_parse(&content)?;
 
-    check_libs_exist(&project.libraries, root)?;
     Ok(project)
 }
 
-fn check_libs_exist(libraries: &[Libraries], root: &Path) -> Result<(), Diagnostic> {
-    for library in libraries {
-        let path = root.join(&library.path);
-        let path = path.join(&format!("lib{}.so", library.name));
-        if !path.is_file() {
-            return Err(Diagnostic::GeneralError {
-                message: format!(
-                    "The library could not be found at : {}",
-                    path.to_string_lossy()
-                ),
-                err_no: ErrNo::general__io_err,
-            });
-        }
-    }
-    Ok(())
-}
-
 #[cfg(test)]
 mod tests {
     use std::path::PathBuf;

src/build.rs

@@ -161,6 +161,14 @@ pub struct CompileParameters {
     )]
     pub error_format: ErrorFormat,
 
+    #[clap(
+        name = "linker",
+        long,
+        help = "Define a custom (cc compatible) linker command",
+        global = true
+    )]
+    pub linker: Option<String>,
+
     #[clap(subcommand)]
     pub commands: Option<SubCommands>,
 }
@@ -624,7 +632,9 @@ mod cli_tests {
             "--target",
             "targettest",
             "--target",
-            "othertarget"
+            "othertarget",
+            "--linker",
+            "cc"
         ))
         .unwrap();
         if let Some(commands) = parameters.commands {
@@ -633,6 +643,7 @@ mod cli_tests {
                     build_config,
                     build_location,
                     lib_location,
+                    ..
                 } => {
                     assert_eq!(build_config, Some("src/ProjectPlc.json".to_string()));
                     assert_eq!(build_location, Some("bin/build".to_string()));
@@ -647,6 +658,7 @@ mod cli_tests {
                 parameters.target,
                 vec!["targettest".to_string(), "othertarget".to_string()]
             );
+            assert_eq!(parameters.linker, Some("cc".to_string()));
         }
     }