Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the newest inkwell version #1104

Open
ghaith opened this issue Feb 21, 2024 · 0 comments
Open

Update to the newest inkwell version #1104

ghaith opened this issue Feb 21, 2024 · 0 comments
Labels
low-priority refactor internal change, cleanup, code-style-improvement

Comments

@ghaith
Copy link
Collaborator

ghaith commented Feb 21, 2024

Inkwell is now on version 0.4
There are a lot of changes to the API, the builder methods all return results now.
We should start considering an update. I believe we would need to introduce thiserror for the codegen or find a way to convert the errors directly into diagnostics.
I'd suggest we plan this after the diagnostics are done so we base on the work there.

@volsa volsa added refactor internal change, cleanup, code-style-improvement low-priority labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority refactor internal change, cleanup, code-style-improvement
Projects
None yet
Development

No branches or pull requests

2 participants