Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin functions #460

Closed
ghaith opened this issue Feb 11, 2022 · 1 comment · Fixed by #511
Closed

Builtin functions #460

ghaith opened this issue Feb 11, 2022 · 1 comment · Fixed by #511
Assignees

Comments

@ghaith
Copy link
Collaborator

ghaith commented Feb 11, 2022

Is your feature request related to a problem? Please describe.

Some features of the standard functions work best as built-in functions provided by the compiler
Examples of such functions are ADR and REF, as well as functions that might take multiple parameters such as MUX, SEL, ADD..

Describe the solution you'd like

We should add support for functions that are always indexed, and generate IR for them on the fly
I suggest we start with ADR, REF and some of the math functions in table 29 of the norm. (ADD..)

Describe alternatives you've considered

Some of the functions are also possible to implement separately, I think we should find a balance here.
Functions that take variadic arguments cannot be implemented in rust, so we should at least provide a mechanism to convert these functions to equivalent callable functions.
Implementing the functions directly as builtin seems easier

@ghaith
Copy link
Collaborator Author

ghaith commented Jun 22, 2022

ADR and REF are in.

Find the balance for the rest as mentioned above

@ghaith ghaith self-assigned this Jun 23, 2022
@ghaith ghaith linked a pull request Jul 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant