Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About LyCORIS #2

Open
KohakuBlueleaf opened this issue Dec 13, 2023 · 1 comment
Open

About LyCORIS #2

KohakuBlueleaf opened this issue Dec 13, 2023 · 1 comment

Comments

@KohakuBlueleaf
Copy link

First of all, thanks you guys implement this kind of useful tools!
But I want to point out some problems or some questions:

  1. LyCORIS is not LyCoris.
  2. I recommend you guys to implement some kind of "plugin system" like kohya(which allowed custom addon network) or HCP-Diffusion(which allowed custom add on layers). So "support new algorithm" can be done by community easily.
  3. If you guys have plugin API, let me know and I can just support your framework in LyCORIS directly. (But actually you can also just import my package and patch the layer you want to patch directly XD)
@caopulan
Copy link
Contributor

caopulan commented Dec 13, 2023

First of all, thanks you guys implement this kind of useful tools! But I want to point out some problems or some questions:

  1. LyCORIS is not LyCoris.
  2. I recommend you guys to implement some kind of "plugin system" like kohya(which allowed custom addon network) or HCP-Diffusion(which allowed custom add on layers). So "support new algorithm" can be done by community easily.
  3. If you guys have plugin API, let me know and I can just support your framework in LyCORIS directly. (But actually you can also just import my package and patch the layer you want to patch directly XD)

Thank you very much for your feedback!

  1. Regarding the spelling, we'll make sure to correct that.
  2. (&3)Your suggestion about implementing a "plugin system" is a great idea. We'll keep you updated on our progress, and if we decide to implement a plugin API, we'll certainly let you know. It would be great to collaborate with LyCORIS in supporting our framework. In the meantime, we'll explore the possibility of importing your package and patching the necessary layers directly. Once again, thank you for your valuable feedback, and we look forward to further discussions and collaborations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants