Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLiT tests don't work with relative paths #165

Closed
mikebentley15 opened this issue Jul 2, 2018 · 1 comment · Fixed by #280
Closed

FLiT tests don't work with relative paths #165

mikebentley15 opened this issue Jul 2, 2018 · 1 comment · Fixed by #280
Assignees
Labels
documentation Involves touching documentation enhancement make Involves touching GNU Makefiles

Comments

@mikebentley15
Copy link
Collaborator

If a test has a relative path, then the full FLiT run as well as the bisect run will fail since they change to different directories. I think this is a downside to FLiT and should be addressed.

I propose that if a test uses a relative path, then it should be relative to the directory that contains the flit-config.toml and custom.mk files. Likely the easiest solution is to run each executable such that the current directory is always the top-level flit tests directory. Another solution is to find a way to give developers an API that allows them to do relative addressing, which seems harder.

@mikebentley15 mikebentley15 added enhancement make Involves touching GNU Makefiles labels Jul 2, 2018
@mikebentley15 mikebentley15 self-assigned this Jul 2, 2018
@mikebentley15
Copy link
Collaborator Author

It looks like the FLiT tests work with relative paths for the full FLiT run. But it does not work with Bisect. So looks like the fix here is only with the Bisect Makefile.

However, we should add to the documentation that it is not recommended to use relative paths in the source code since it can make the executables in the results directory not able to be run.

See #50

@mikebentley15 mikebentley15 added the documentation Involves touching documentation label Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Involves touching documentation enhancement make Involves touching GNU Makefiles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant