Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler-specific flags not used in Bisect #307

Closed
mikebentley15 opened this issue Dec 12, 2019 · 0 comments · Fixed by #309
Closed

Compiler-specific flags not used in Bisect #307

mikebentley15 opened this issue Dec 12, 2019 · 0 comments · Fixed by #309
Labels
bug documentation Involves touching documentation good first issue A good place to start make Involves touching GNU Makefiles python Involves touching python code question tests Involves touching tests

Comments

@mikebentley15
Copy link
Collaborator

Bug Report

Describe the problem
We have added compiler-specific flags with issue #125 (and associated pull request #301). These compiler-specific flags are in flit-config.toml. However, this was only done for the main generated Makefile, but not for Bisect Makefiles.

When running Bisect, the baseline compilation continues to use the compiler-specific flags. However, the compilation under test does not.

Suggested Fix
If the compiler specified in the compilation under test is specified in flit-config.toml, then take the compiler flags from there for generating object files.

But, if the compiler specified in the compilation under test is not found in flit-config.toml, then continue as we do now.

Question:
The links step is still done with the baseline compilation, so the link flags for the baseline compiler will be used. Should we do anything with the compiler-specific link flags for the compilation under test?

Alternative approaches:
I can't think of any. It seems a bit ridiculous to require the user to specify the fixed flags in the bisect command-line as well as in flit-config.toml. Think for instance if it is the same compiler as the baseline, but with a different optimization level and a different set of switches.

@mikebentley15 mikebentley15 added bug question good first issue A good place to start python Involves touching python code make Involves touching GNU Makefiles documentation Involves touching documentation tests Involves touching tests labels Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Involves touching documentation good first issue A good place to start make Involves touching GNU Makefiles python Involves touching python code question tests Involves touching tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant