Compiler-specific flags not used in Bisect #307
Labels
bug
documentation
Involves touching documentation
good first issue
A good place to start
make
Involves touching GNU Makefiles
python
Involves touching python code
question
tests
Involves touching tests
Bug Report
Describe the problem
We have added compiler-specific flags with issue #125 (and associated pull request #301). These compiler-specific flags are in
flit-config.toml
. However, this was only done for the main generatedMakefile
, but not for BisectMakefile
s.When running Bisect, the baseline compilation continues to use the compiler-specific flags. However, the compilation under test does not.
Suggested Fix
If the compiler specified in the compilation under test is specified in
flit-config.toml
, then take the compiler flags from there for generating object files.But, if the compiler specified in the compilation under test is not found in
flit-config.toml
, then continue as we do now.Question:
The links step is still done with the baseline compilation, so the link flags for the baseline compiler will be used. Should we do anything with the compiler-specific link flags for the compilation under test?
Alternative approaches:
I can't think of any. It seems a bit ridiculous to require the user to specify the fixed flags in the bisect command-line as well as in
flit-config.toml
. Think for instance if it is the same compiler as the baseline, but with a different optimization level and a different set of switches.The text was updated successfully, but these errors were encountered: