Decouple ext scorer init & inference & decoding for the convenience o… #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 12, 2018 21:53
pkuyym
reviewed
Jan 15, 2018
infer.py
Outdated
| language_model_path=args.lang_model_path, | ||
| num_processes=args.num_proc_bsearch, | ||
| feeding_dict=data_generator.feeding) | ||
| if args.decoding_method == "ctc_beam_search": |
There was a problem hiding this comment.
If ctc_greedy doesn't require the external score, I think it's better to move this if after line 104
model_utils/model.py
Outdated
| language_model_path, num_processes, feeding_dict): | ||
| """Model inference. Infer the transcription for a batch of speech | ||
| utterances. | ||
| def infer_probs_batch(self, infer_data, feeding_dict): |
There was a problem hiding this comment.
Please keep the naming consistent. Like below decode_batch_beam_search, please change infer_probs_batch to infer_batch_probs.
| rnn_size=args.rnn_layer_size, | ||
| use_gru=args.use_gru, | ||
| share_rnn_weights=args.share_rnn_weights) | ||
| keep_transcription_text=True) | ||
|
|
||
| batch_reader = data_generator.batch_reader_creator( | ||
| manifest_path=args.tune_manifest, | ||
| batch_size=args.batch_size, | ||
| sortagrad=False, | ||
| shuffle_method=None) | ||
|
|
There was a problem hiding this comment.
Why removed the validation for model path here ?
kuke
commented
Jan 15, 2018
infer.py
Outdated
| language_model_path=args.lang_model_path, | ||
| num_processes=args.num_proc_bsearch, | ||
| feeding_dict=data_generator.feeding) | ||
| if args.decoding_method == "ctc_beam_search": |
model_utils/model.py
Outdated
| language_model_path, num_processes, feeding_dict): | ||
| """Model inference. Infer the transcription for a batch of speech | ||
| utterances. | ||
| def infer_probs_batch(self, infer_data, feeding_dict): |
Jackwaterveg
pushed a commit
to Jackwaterveg/DeepSpeech
that referenced
this pull request
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #121
Fix #120
Fix #117