【stride】Set value when dstplace != srcplace and one tenosr is not contiguous should add check (#75794)

* add log

* fix bug

* fix

* delete

* fix conflict

* fix test

Author: xiaoguoguo626807

paddle/fluid/pybind/eager_method.cc

@@ -1434,7 +1434,8 @@ static PyObject* tensor_method_set_underline_tensor(TensorObject* self,
           static_cast<phi::DenseTensor*>(self->tensor.impl().get());
       if (self->tensor.has_allocation() && self->tensor.initialized() &&
           (!dst_tensor->meta().is_contiguous() ||
-           !src_tensor->meta().is_contiguous())) {
+           !src_tensor->meta().is_contiguous()) &&
+          dst_tensor->place().GetType() == src_tensor->place().GetType()) {
         VLOG(8) << "set_tensor() method , src or dst tensor is not contiguous ";
         if (!FLAGS_use_stride_kernel) {
           PADDLE_THROW(common::errors::Fatal(
@@ -1451,6 +1452,17 @@ static PyObject* tensor_method_set_underline_tensor(TensorObject* self,
                   dst_tensor);
             }));
       } else {
+        if (!dst_tensor->meta().is_contiguous()) {
+          PADDLE_THROW(common::errors::Fatal(
+              "dst_tensor is not contiguous and src_tesnor has different place "
+              "with dst_tensor, so Strided kernel "
+              "can't be called, please change src_tensor'place as same as "
+              "dst_tensor'place or change dst_tensor to be contiguous"));
+        } else if (!src_tensor->meta().is_contiguous()) {
+          VLOG(6) << "src_tensor is not contiguous, so dst_tensor will be not "
+                     "contiguous after set_value ";
+        }
+
         if (dst_tensor->place().GetType() != phi::AllocationType::UNDEFINED) {
           framework::TensorCopy(*src_tensor, dst_tensor->place(), dst_tensor);
         } else if (src_tensor->place().GetType() !=

test/legacy_test/test_set_value_op.py

@@ -1788,5 +1788,36 @@ def test_value_input_is_scalar(self):
         np.testing.assert_array_equal(x.grad, expected_x_grad)
 
 
+@unittest.skipIf(
+    not (core.is_compiled_with_cuda() or is_custom_device()),
+    "core is not compiled with CUDA",
+)
+class TestSetValueWithStrideError(unittest.TestCase):
+    def test_same_place(self):
+        x = paddle.rand([5, 10], device=paddle.CUDAPlace(0))
+        y = paddle.rand([10, 5], device=paddle.CUDAPlace(0))
+        y.transpose_([1, 0])
+        x.set_value(y)
+        assert x.is_contiguous()
+
+    def test_different_place1(self):
+        # src place != dst place && src is not contiguous
+        x = paddle.rand([5, 10], device=paddle.CUDAPlace(0))
+        y = paddle.rand([10, 5], device=paddle.CPUPlace())
+        y.transpose_([1, 0])
+        x.set_value(y)
+        assert not x.is_contiguous()
+
+    def test_different_place2(self):
+        # src place != dst place && dst is not contiguous
+        with self.assertRaises(SystemError):
+            x = paddle.ones([5, 4], device=paddle.CUDAPlace(0))
+            x.transpose_([1, 0])
+            y = paddle.rand([4, 2], device=paddle.CPUPlace())
+            assert not x.is_contiguous()
+
+            x[:, 1:3].set_value(y)
+
+
 if __name__ == '__main__':
     unittest.main()