Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming rules in MKLDNN related codes #11139

Closed
luotao1 opened this issue Jun 4, 2018 · 2 comments
Closed

Naming rules in MKLDNN related codes #11139

luotao1 opened this issue Jun 4, 2018 · 2 comments
Labels
Intel

Comments

@luotao1
Copy link
Contributor

luotao1 commented Jun 4, 2018

Paddle use CamelCase naming convention. For example, all the functions of pool_op.cc use CamelCase naming convention, but pool_mkldnn_op.cc use gethash, not GetHash. Could you please go over all the MKLDNN related codes in fluid version, and correct it? @jczaja @kbinias @mozga-intel @pzelazko-intel @tpatejko
@luotao1 luotao1 added the Intel label Jun 4, 2018
@mozga-intel
Copy link
Contributor

mozga-intel commented Jun 4, 2018 •
edited
Loading

@luotao1 Thank you for your issue. If the mkldnn layout will be ready to merge, the changes will be visible in these PR.

@luotao1
Copy link
Contributor Author

luotao1 commented Jun 5, 2018

@mozga-intel I see it, thanks very much!

@luotao1 luotao1 closed this as completed Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luotao1 @mozga-intel