Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move third_party directory into build #2570

Closed
wangkuiyi opened this issue Jun 22, 2017 · 1 comment
Closed

Move third_party directory into build #2570

wangkuiyi opened this issue Jun 22, 2017 · 1 comment
Assignees

Comments

@wangkuiyi
Copy link
Collaborator

The building process, in particular, cmake/external/*.cmake, creates third_party/. If we want a brand new build, we will need to remove both ${CMAKE_BINARY_DIR}, which is build/, and third_party/.

Some new users don't know all these and remove only build/ with failed expectation of brand new build.

@wangkuiyi
Copy link
Collaborator Author

I noticed that in our Travis CI configuration, we are placing thrid_party in $HOME/third_party and we asked Travis CI to cache it:

cache:
  directories:
    - $HOME/third_party
    - $HOME/.ccache
    - $HOME/.cache/pip

This accelerates the building and testing, but it also increased the complexity of our code base, as explained in #2571.

Also, as we have been using TeamCity CI for a while; and we don't do the cache there. It seems that the building and testing of both CPU and GPU code take ~15 mins. It seems that we don't really depend on this caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant