Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation path and build_doc problems of Mkldnn #3162

Closed
luotao1 opened this issue Aug 2, 2017 · 2 comments · Fixed by #3168
Closed

Installation path and build_doc problems of Mkldnn #3162

luotao1 opened this issue Aug 2, 2017 · 2 comments · Fixed by #3168

Comments

@luotao1
Copy link
Contributor

luotao1 commented Aug 2, 2017

Though #3096 is closed, there are two commits should be merged at first.

  • The installation path of Mkldnn is in /home/user/opt/paddle/thirdparty currently. We should move it paddle/thirdparty, where all other thirdparty libraries located. e9e6a81
  • build_doc in travis-ci will be failed if -DWITH_MKLDNN=True -DWITH_MKLML=True. We should set it false when generating document. 4dd31e8

@tensor-tang will implement it. Thx!

@tensor-tang
Copy link
Contributor

Sure, will update soon.

But, one point to be clarify:
Because MKLDNN and MKLML *.so move to build/third_party, then build doc will fail as it will remove all *.so before build doc.
Then , we will need to disable MKLDNN and MKLML when build doc.

This should lead to another issue to figure out how to integrate those so files into paddle whl.
We should follow it later.

@luotao1
Copy link
Contributor Author

luotao1 commented Aug 4, 2017

This should lead to another issue to figure out how to integrate those so files into paddle whl.
We should follow it later.

The issue is #3213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants