Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add passes that add mkldnn related attributes instead of changing native ops #38856

Closed
lidanqing-intel opened this issue Jan 10, 2022 · 5 comments · Fixed by #36541
Closed
Assignees
Labels
Milestone

Comments

@lidanqing-intel
Copy link
Contributor

lidanqing-intel commented Jan 10, 2022

Use passes to add mkldnn related attributes instead of changing native ops
@tsocha

@paddle-bot-old
Copy link

您好,我们已经收到了您的问题,会安排技术人员尽快解答您的问题,请耐心等待。请您再次检查是否提供了清晰的问题描述、复现代码、环境&版本、报错信息等。同时,您也可以通过查看官网API文档常见问题历史IssueAI社区来寻求解答。祝您生活愉快~

Hi! We've received your issue and please be patient to get responded. We will arrange technicians to answer your questions as soon as possible. Please make sure that you have posted enough message to demo your request. You may also check out the APIFAQGithub Issue and AI community to get the answer.Have a nice day!

@jakpiase
Copy link
Contributor

Is there any example on how can we add attributes in inference stage?

@lidanqing-intel
Copy link
Contributor Author

@tsocha is working on the design you can discuss with him. We need to get more info from Baidu about compatibility requirements.

@lidanqing-intel
Copy link
Contributor Author

lidanqing-intel commented Jan 14, 2022

Meeting notes

  1. Not removing any attributes that already exist in native op
  2. Serilizartion: If you follow register_op steps, it will be serilizaed
  3. About naming conv_oneDNN_op.cc

Question1: GPU training. CPU mkldnn training is working now. If adding this new mkldnn custom op, will it work on GPU training.This custom op is through passes, and training doesn't have such passes, so it should not affect. Is it callable from python. If it is callable it will influence training. Tomasz answer is no such plan for this.

Question2: How does this mkldnn custom op support eager mode which is most popular.

@lidanqing-intel lidanqing-intel added this to the 2022 Q1 milestone Jan 17, 2022
@lidanqing-intel
Copy link
Contributor Author

related to #36541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants