Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add CI of build_android back #6111

Closed
Xreki opened this issue Nov 30, 2017 · 3 comments
Closed

Need to add CI of build_android back #6111

Xreki opened this issue Nov 30, 2017 · 3 comments
Assignees

Comments

@Xreki
Copy link
Contributor

Xreki commented Nov 30, 2017

Current PR often make the build of mobile failed. When I build for Android using the current develop branch, I met the following error:

  • CMake warning
-- Configuring done
CMake Error at paddle/testing/CMakeLists.txt:10 (add_dependencies):
  The dependency target "paddle_memory" of target "paddle_gtest_main" does
  not exist.


  • Make error
[ 84%] Building CXX object paddle/testing/CMakeFiles/paddle_gtest_main.dir/paddle_gtest_main.cc.o
In file included from /home/work/liuyiqun/PaddlePaddle/Paddle/paddle/platform/place.h:19:0,
                 from /home/work/liuyiqun/PaddlePaddle/Paddle/paddle/memory/memory.h:17,
                 from /home/work/liuyiqun/PaddlePaddle/Paddle/paddle/testing/paddle_gtest_main.cc:18:
/home/work/liuyiqun/PaddlePaddle/Paddle/paddle/platform/variant.h:17:28: fatal error: boost/config.hpp: No such file or directory
 #include <boost/config.hpp>
                            ^
compilation terminated.
make[2]: *** [paddle/testing/CMakeFiles/paddle_gtest_main.dir/paddle_gtest_main.cc.o] Error 1
make[1]: *** [paddle/testing/CMakeFiles/paddle_gtest_main.dir/all] Error 2
make: *** [all] Error 2

The error is caused by PR #5476. In fact, there is no need to build the source file paddle_gtest_main.cc.

We need to add CI of build_android back to make sure cross-compiling always successful.

@Xreki Xreki added the Android label Nov 30, 2017
@Yancey0623
Copy link
Contributor

Will do this, and for another, what kind of trigger do you suggest? nightly or after merged?

@Yancey0623 Yancey0623 self-assigned this Nov 30, 2017
@Xreki
Copy link
Contributor Author

Xreki commented Nov 30, 2017

I think it should be triggered by each commit in PR. Every PR should ensure it does not fail the building of Android.

Previously, I have added a build_android task in travis, and removed it for some reason. I am not sure where to add it, travis or teamcity? It seems the teamcity is slow now (~ 35 mins).

@Yancey0623
Copy link
Contributor

I created a project on teamCity: https://paddleci.ngrok.io/viewType.html?buildTypeId=Paddle_BuildAndroid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants