Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build-from-source doc has content duplicate with the build-using-docker one #6311

Closed
wangkuiyi opened this issue Dec 5, 2017 · 6 comments
Assignees

Comments

@wangkuiyi wangkuiyi self-assigned this Dec 5, 2017
@luotao1
Copy link
Contributor

luotao1 commented Dec 6, 2017

@typhoonzero and I discussed in #5941 (sorry, it is a Chinese issue), build-using-docker is a nice article for blog, and we decide to remain build-from-source, and put build-using-docker into our blog repo later. Thus, we do following things:

  • build-from-source describes how to build-using-docker as well.
# run the following command to build a CPU-Only binaries if you are using docker
docker run -it -v $PWD:/paddle -e "WITH_GPU=OFF" -e "WITH_TESTING=OFF" paddlepaddle/paddle_manylinux_devel:cuda8.0_cudnn5 bash -x paddle/scripts/docker/build.sh
# else run these commands
mkdir build

So can we remove the link of build-using-docker again after #6306 ?

@typhoonzero
Copy link
Contributor

I thought it will be great if we put build-using-docker to blog as a "best practice" post and extend the documents. Then we can make the document simple and clear.

@wangkuiyi
Copy link
Collaborator Author

I think PaddlePaddle contributors should use Docker to unique their development environments. Otherwise, it would be even difficult to report building problems in issues, and it would be hard for us to figure out the reasons.

I agree that Docker-based building process should generate wheel packages (or other pip-installable formats) so that DL researchers could do pip install paddle and don't have to rely on Docker.

@typhoonzero
Copy link
Contributor

@luotao1 @wangkuiyi Can we merge build from docker document contents to build from source and make Docker build method our only official supported build method? And make build from docker shorter?

@luotao1
Copy link
Contributor

luotao1 commented Dec 12, 2017

Can we merge build from docker document contents to build from source and make Docker build method our only official supported build method?

I agree it. But what's the new title? Still build from source?

  • Install and Build
    • Install Using pip
    • Run in Docker Containers
    • Build from Sources

@luotao1
Copy link
Contributor

luotao1 commented Jul 16, 2018

@luotao1 luotao1 closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants