Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we rename ProgramDescBind to ProgramDesc? #6544

Closed
helinwang opened this issue Dec 12, 2017 · 2 comments
Closed

Should we rename ProgramDescBind to ProgramDesc? #6544

helinwang opened this issue Dec 12, 2017 · 2 comments
Assignees

Comments

@helinwang
Copy link
Contributor

helinwang commented Dec 12, 2017

When looking at the ProgramDescBind, my first impression is it's only an auxiliary class for ProgramDesc. But actually it's the real "ProgramDesc" that gets passed between modules (e.g., gets passed into Executor), the current ProgramDesc is just a proto c++ class for the wire format.

I think to avoid confusion, we should rename ProgramDescBind (already lives in program_desc.cc) to ProgramDesc, and put the current ProgramDesc under proto namespace (or rename to ProgramDescProto).

How do you guys think?

@reyoung
Copy link
Collaborator

reyoung commented Dec 13, 2017

If we decide to do this, I can help to rename this class, since rename is easier by IDE.

@reyoung
Copy link
Collaborator

reyoung commented Dec 19, 2017

I will complete this issue by following steps:

  1. Move framework.proto to proto namespace
  2. Rename XXXBind to XXX

@QiJune QiJune closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants