Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low code coverage on latest develop branch #7569

Closed
typhoonzero opened this issue Jan 16, 2018 · 0 comments
Closed

Low code coverage on latest develop branch #7569

typhoonzero opened this issue Jan 16, 2018 · 0 comments

Comments

@typhoonzero
Copy link
Contributor

How to generate the coverage:

  1. Modify coveralls.cmake CMAKE_BUILD_TYPE to Release, this can be fixed soon.
  2. Run cmake -DWITH_COVERAGE=ON -DCOVERALLS_UPLOAD=ON [other options] .., must compile WITH_GPU=ON since CPU only unit test fails on some operators. #7546 is not fixed.
  3. Run make coveralls. It will probably fail because it's not running on a CI system.
  4. Run pip install cpp-coveralls to install a tool to upload coveralls data.
  5. Run coveralls --exclude CMakeFiles --exclude go --exclude proto --exclude python --exclude third_party --exclude Testing --gcov-options '\-lp' --dump new_coveralls.json to get a newly updated json
  6. Modify the .json file to remove service_job_id and service_name field, and add repo_token of PaddlePaddle (Ask PaddlePaddle admin for it.).
  7. Run curl -X POST -F json_file=@new_coveralls.json https://coveralls.io/api/v1/jobs
  8. Visit https://coveralls.io/github/PaddlePaddle/Paddle to see detailed information.

The problem

Current coverage is generated using gconv, and fluid uses python to test c++ code, we can not get coverage across languages. So need to find a way to get it more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants