Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move framework/detail/tensor-inl.h to framework/tensor-impl.h #3194

Closed
wangkuiyi opened this issue Aug 3, 2017 · 0 comments
Closed

Move framework/detail/tensor-inl.h to framework/tensor-impl.h #3194

wangkuiyi opened this issue Aug 3, 2017 · 0 comments
Assignees
@wangkuiyi

Comments

@wangkuiyi
Copy link
Collaborator

Google C++ Style Guide https://google.github.io/styleguide/cppguide.html#Namespace_Names requires that the C++ namespace hierarchy matches the directory hierarchy.

Given that contents in tensor-inl.h have to be in namespace paddle::framework, we'd move the file up one level to framework directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangkuiyi wangkuiyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wangkuiyi