Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gelu convert test #35529

Merged
merged 15 commits into from
Sep 15, 2021
Merged

Add gelu convert test #35529

merged 15 commits into from
Sep 15, 2021

Conversation

JZZ-NOTE
Copy link
Contributor

@JZZ-NOTE JZZ-NOTE commented Sep 7, 2021 •
edited
Loading

PR types

Others

PR changes

OPs

Describe

  1. 在 op_teller 中添加 gelu 算子的 approximate 属性过滤（trt不支持该属性）
  2. 添加 gelu 算子单测，测试 op_teller 是否发挥作用，不同输入 shape 情况
  3. 测试结果：在 一维输入时，静态测试报错：segmentation fault，在 op_teller中过滤
  4. 新暴露的问题：在输入为2维时，trt 会输出4维，例如 输入为 [3,64]，trt(plugin) 会输出 [3,64,1,1]

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 7, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jiweibo
jiweibo approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit 39dcfc6 into PaddlePaddle:develop Sep 15, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@JZZ-NOTE @xiaoxiaohehe001 @AnnaTrainingG
Add gelu convert test (PaddlePaddle#35529)
9ce6dcd 

Co-authored-by: xiaoxiaohehe001 <hiteezsf@163.com>
@JZZ-NOTE JZZ-NOTE deleted the add_gelu_test branch April 13, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhizhou shangzhizhou shangzhizhou left review comments

@jiweibo jiweibo jiweibo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JZZ-NOTE @jiweibo @shangzhizhou @xiaoxiaohehe001