Fix readme #211
Merged
Fix readme #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
requested changes
Jul 12, 2017
README.md
Outdated
| npm install | ||
| pip install -r requirements.txt | ||
| ./manage.py migrate | ||
| ./manage.py loaddata sites | ||
| npm run dev | ||
| ``` | ||
|
|
||
| If `npm` haven't been installed, you need to |
There was a problem hiding this comment.
The command may differ for different OSs, just add one line in Pre-Requirements: "nodejs"
README.md
Outdated
| - Copy Kubernetes admin user key (admin.pem, admin-key.pem) to `pcloud_data/certs` folder | ||
| - Copy CephFS Key file(admin.secret) to `pcloud_data/certs` folder | ||
| - Copy `/paddlecloud/settings.py` file to `pcloud_data` folder | ||
| - Copy Kubernetes CA files (ca.pem, ca-key.pem, ca.srl) to `pcloud/data/certs` folder |
There was a problem hiding this comment.
Maybe not put strict folders here, the folders are used by k8s/cloud_deployment.yaml, and these folders need to be full path begin from /. So users need to define their own hostpath for yaml files to use.
typhoonzero
reviewed
Jul 19, 2017
| @@ -9,3 +9,4 @@ kubernetes | |||
| MySQL-python | |||
| djangorestframework | |||
| django_sendmail_backend | |||
| nodejs | |||
There was a problem hiding this comment.
Dockerfile already have this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs