-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notebook errors #223
Fix notebook errors #223
Conversation
- name: mysql-data | ||
mountPath: /var/lib/mysql | ||
env: | ||
- name: MYSQL_ROOT_PASSWORD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要加上:https://github.com/PaddlePaddle/cloud/blob/develop/k8s/cloud_deployment.yaml#L82
- name: MYSQL_DATABASE
value:paddlecloud
没有数据库就创建一个。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
k8s/cloud_deployment.yaml
Outdated
nodeSelector: | ||
kubernetes.io/hostname: k8s-node1 | ||
kubernetes.io/hostname: your-host-name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个我不是很清楚,这个的值在哪里设置?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
根据集群配置节点。不是固定的值
@@ -17,7 +17,7 @@ | |||
</script> | |||
{% if notebook_status == "running" %} | |||
<div class="container fullheight"> | |||
<iframe src="http://cloud.paddlepaddle.org/notebook/{{ notebook_id }}" width="100%" height="500" style="border:none;"></iframe> | |||
<iframe src="/notebook/{{ notebook_id }}" width="100%" height="500" style="border:none;"></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
赞!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #222
Run mysql and paddlecloud in different pods.
Fix #224