Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook errors #223

Merged
merged 4 commits into from
Jul 24, 2017
Merged

Conversation

typhoonzero
Copy link
Collaborator

@typhoonzero typhoonzero commented Jul 17, 2017

Fix #222

Run mysql and paddlecloud in different pods.
Fix #224

- name: mysql-data
mountPath: /var/lib/mysql
env:
- name: MYSQL_ROOT_PASSWORD
Copy link
Collaborator

@gongweibao gongweibao Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要加上:https://github.com/PaddlePaddle/cloud/blob/develop/k8s/cloud_deployment.yaml#L82

- name: MYSQL_DATABASE
  value:paddlecloud

没有数据库就创建一个。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

nodeSelector:
kubernetes.io/hostname: k8s-node1
kubernetes.io/hostname: your-host-name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我不是很清楚,这个的值在哪里设置?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根据集群配置节点。不是固定的值

@@ -17,7 +17,7 @@
</script>
{% if notebook_status == "running" %}
<div class="container fullheight">
<iframe src="http://cloud.paddlepaddle.org/notebook/{{ notebook_id }}" width="100%" height="500" style="border:none;"></iframe>
<iframe src="/notebook/{{ notebook_id }}" width="100%" height="500" style="border:none;"></iframe>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞!

gongweibao
gongweibao previously approved these changes Jul 24, 2017
Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yancey1989
Yancey1989 previously approved these changes Jul 24, 2017
Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM

@typhoonzero typhoonzero dismissed stale reviews from Yancey1989 and gongweibao via e4e2101 July 24, 2017 03:43
Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit eb9cf06 into PaddlePaddle:develop Jul 24, 2017
@typhoonzero typhoonzero deleted the fix_notebook branch November 2, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants