Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add paddle cloud figure #597

Merged
merged 3 commits into from
Feb 6, 2018
Merged

Add paddle cloud figure #597

merged 3 commits into from
Feb 6, 2018

Conversation

wangkuiyi
Copy link

@wangkuiyi wangkuiyi commented Feb 6, 2018 •
edited
Loading

Fix #593

@wangkuiyi
Copy link
Author

I didn't draw pfs server in this figure. Is pfs a HTTP server behind the paddlecloud HTTP server? Is that the paddlecloud server might proxy some HTTP requests to pfs?

@gongweibao
Copy link
Collaborator

gongweibao commented Feb 6, 2018 •
edited
Loading

Yep.I add it to this picture.
image

@wangkuiyi
Copy link
Author

Thanks! @gongweibao I updated the figure following yours.

gongweibao
gongweibao approved these changes Feb 6, 2018
View reviewed changes
Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangkuiyi wangkuiyi merged commit 8c14639 into PaddlePaddle:develop Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongweibao gongweibao gongweibao approved these changes

@Yancey1989 Yancey1989 Awaiting requested review from Yancey1989

@helinwang helinwang Awaiting requested review from helinwang

@putcn putcn Awaiting requested review from putcn

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangkuiyi @gongweibao