【Hackathon 4th No.20】Updated paddle.i0 / paddle.i0e API rfc doc #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
提案已更新，@zhengqiwen1997 辛苦重新 review，@luotao1 麻烦重新 merge。 |
|
对于：六、测试和验收的考量 部分。验收参考对比numpy结果方便吗？@LyndonKong 同学对比scipy结果应该验证起来更简单吧？ |
先前的提案我认为也是使用 scipy 更好，但是在写单测的过程中发现 paddle 本身没有依赖 scipy，不太好过线上单测，我是出于这个考虑，那需要进行修改么。 |
|
我们的单测试支持scipy的呀。建议能用scipy还是用吧～ |
噢噢噢噢，抱歉抱歉😨，之前好像某次在线上环境报错了之后就换成了 numpy，原来是支持的，那我这边修改一下 |
|
已修改 |
zhengqiwen1997
approved these changes
Mar 29, 2023
luotao1
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #478, updated paddle.i0 / paddle.i0e doc, consider the implementation of Tensorflow and use the Eigen3 library as the solution.