Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/pagerduty_maintenance_window: Allow services to be unordered #142

Merged

Conversation

heimweh
Copy link
Collaborator

@heimweh heimweh commented Jul 30, 2019

This PR changes the type for services from TypeList to TypeSet.
Fixes the following issue: https://github.com/terraform-providers/terraform-provider-pagerduty/issues/137 by allowing us to pass an unordered list of services.

Copy link

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heimweh heimweh merged commit 5f2d1be into PagerDuty:master Jul 31, 2019
@heimweh heimweh deleted the ah/maintenance-window-services-order branch July 31, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants