Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: Add support for alert_grouping and alert_grouping_timeout #143

Merged
merged 4 commits into from
Aug 1, 2019
Merged

service: Add support for alert_grouping and alert_grouping_timeout #143

merged 4 commits into from
Aug 1, 2019

Conversation

pengux
Copy link
Contributor

@pengux pengux commented Jul 31, 2019

For the service resource, add support for the attributes alert_grouping and alert_grouping_timeout

Acceptance tests

⇒  TF_ACC=1 go test -run "TestAccPagerDutyService_AlertGrouping" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyService_AlertGrouping
--- PASS: TestAccPagerDutyService_AlertGrouping (26.77s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   26.828s

@ghost ghost added the size/L label Jul 31, 2019
@ghost ghost added the dependencies label Jul 31, 2019
@heimweh
Copy link
Collaborator

heimweh commented Jul 31, 2019 •
edited
Loading

Hi @pengux,

thank you so much for this PR. This looks good! 👍
Would you mind updating the documentation as well? 🙏

@ghost ghost added the documentation label Aug 1, 2019
@pengux
Copy link
Contributor Author

pengux commented Aug 1, 2019

Hi @pengux,

thank you so much for this PR. This looks good! 👍
Would you mind updating the documentation as well? 🙏

I've updated the documentation

heimweh
heimweh approved these changes Aug 1, 2019
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pengux,

thank you so much for this! This LGTM 👍

@heimweh heimweh merged commit 0239509 into PagerDuty:master Aug 1, 2019
@islomar islomar deleted the pn/service-alert-grouping branch August 2, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
dependencies documentation enhancement size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengux @heimweh