Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing user referenced by team membership #153

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Sep 17, 2019

Same as https://github.com/terraform-providers/terraform-provider-pagerduty/pull/30 but for team membership.

Without this change, if a user is deleted from Pagerduty, refreshing a team membership fails with the following message:

Error: GET API call to https://api.pagerduty.com/users/PWR**** failed 404 Not Found. Code: 2100, Errors: <nil>, Message: Not Found

@ghost ghost added the size/XS label Sep 17, 2019
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @pdecat 🙏
This LGTM 👍

@heimweh heimweh merged commit bd09ae5 into PagerDuty:master Sep 17, 2019
@pdecat pdecat deleted the team_membership_404 branch September 17, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants