Allow disabling service incident timeouts (take 2)

[pdecat]

Resolves #51 (and #41 for good).

Checklist:

• add test case
• implement fix
• update documentation
• update vendored go-pagerduty once upstream PR Make AcknowledgementTimeout and AutoResolveTimeout fields integer pointers heimweh/go-pagerduty#20 is merged
• remove [WIP] marker

Rationale:

This PR changes auto_resolve_timeout and acknowledgement_timeout fields from int to string type to allow passing a "null" value which means disabled as documented at https://v2.developer.pagerduty.com/v2/page/api-reference#!/Services/post_services

My previous fix in #44 did not work as expected as 0 effectively means 0 second, resulting in incidents to be instantaneously marked as resolved.

To avoid backward incompatible changes to existing terraform configurations, I preserved the default API values of 4h for auto_resolve_timeout and 30 minutes for acknowledgement_timeout.
Note that those are not explicitely stated in the v2 API documentation so I got them from the API v1: https://v1.developer.pagerduty.com/documentation/rest/services/create

I'm preparing a PR for go-pagerduty to remove the local vendor patch.

Acceptance tests results:

make testacc TEST=./pagerduty/ TESTARGS='-run=TestAccPagerDutyService_.*'                                         
==> Checking that code complies with gofmt requirements...                                   
TF_ACC=1 go test ./pagerduty/ -v -run=TestAccPagerDutyService_.* -timeout 120m               
=== RUN   TestAccPagerDutyService_import      
--- PASS: TestAccPagerDutyService_import (11.78s)
=== RUN   TestAccPagerDutyService_Basic
--- PASS: TestAccPagerDutyService_Basic (21.37s)
=== RUN   TestAccPagerDutyService_BasicWithIncidentUrgencyRules
--- PASS: TestAccPagerDutyService_BasicWithIncidentUrgencyRules (15.78s)
=== RUN   TestAccPagerDutyService_FromBasicToCustomIncidentUrgencyRules
--- PASS: TestAccPagerDutyService_FromBasicToCustomIncidentUrgencyRules (17.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   66.371s

[pdecat]

Expected travis failure given the local vendor patch:

$ make vendor-status
The following packages are missing or modified locally:
	github.com/heimweh/go-pagerduty/pagerduty
Error: status failed for 1 package(s)
make: *** [vendor-status] Error 2
The command "make vendor-status" exited with 2.

[heimweh]

Hi @pdecat,

thanks for this PR and the detailed description!

I've ran the acceptance tests as well as tested this manually and can confirm that this is working correctly.

Since the current behavior is broken and you've solved the BC issue and updated the documentation I feel like this should be safe and good to go 👍

Huge thanks for this, is there anything you want to add or can I go ahead and merge this?

Best,

Alexander

[pdecat]

Hi @heimweh,

from my point of view, it is good to merge.

Best regards,
Patrick.

[jtsaito]

@pdecat Great job!
@heimweh Can we expect a new release with this fix soon?